boot-packages/booster
3
0
Fork 1
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

kernel install hooks #3

Open
cybik wants to merge 1 commits from cybik/booster:main into main
pull from: cybik/booster:main
merge into: boot-packages:main
Conversation 0 Commits 1 Files Changed 3 +11
cybik commented 2024-09-17 00:32:50 +02:00
Member
Copy Link

Automatic regen script!

Automatic regen script!
cybik force-pushed main from 0e115a6cd1 to 76c12047be 2024-09-17 02:57:46 +02:00 Compare
cybik force-pushed main from 76c12047be to dcf7caddf0 2024-09-17 03:06:15 +02:00 Compare
cybik force-pushed main from dcf7caddf0 to 063e92cccb 2024-09-18 19:41:04 +02:00 Compare
ferreo reviewed 2024-09-20 16:37:16 +02:00
Makefile Outdated
@ -14,2 +14,4 @@
install -Dp -m755 ./update-initramfs "$(DESTDIR)/usr/lib/booster/update-initramfs"
install -Dp -m755 ./packaging/pikaos/regenerate_uki "$(DESTDIR)/usr/sbin/regenerate_uki"
install -Dp -m755 ./packaging/pikaos/regenerate_uki-prerm "$(DESTDIR)/etc/kernel/prerm.d/regenerate_uki"
install -Dp -m755 ./packaging/pikaos/regenerate_uki-postinst "$(DESTDIR)/etc/kernel/postinst.d/zzz-regenerate_uki"
ferreo commented 2024-09-20 16:37:10 +02:00
Owner
Copy Link

These gonna run even when someone doesn't care about generating a uki?

These gonna run even when someone doesn't care about generating a uki?
cybik commented 2024-09-22 00:34:31 +02:00
Author
Member
Copy Link

Yes, but they're gonna fail through. I adjusted the scripts so that if the person does not have the required packages and executables (jq, sbctl) are not present, then the whole thing just falls through silently.

Yes, but they're gonna fail through. I adjusted the scripts so that if the person does *not* have the required packages and executables (jq, sbctl) are *not* present, then the whole thing just falls through silently.
cybik commented 2024-09-22 04:18:30 +02:00
Author
Member
Copy Link

And one small bit to add.

The postinst script has a line specifically dealing with this:

[ "$( ${SBCTL_COMMAND} status --json | ${JQ_COMMAND} .installed )" == "true" ] || { exit 0; }

In short, even if sbctl is installed, unless sbctl reports itself as installed, the scripts don't do anything. If, however, sbctl reports itself as installed, the scripts will assume the user will want to leverage auto-UKIfication as well as automatic secureboot UKI signing.

And one small bit to add. The `postinst` script has a line *specifically* dealing with this: ``` [ "$( ${SBCTL_COMMAND} status --json | ${JQ_COMMAND} .installed )" == "true" ] || { exit 0; } ``` In short, even if `sbctl` is installed, unless sbctl reports itself as ***installed***, the scripts don't do anything. ***If***, however, `sbctl` reports itself as installed, the scripts **will** assume the user will want to leverage auto-UKIfication as well as automatic secureboot UKI signing.
cybik force-pushed main from 82f0f96dc4 to 9bb363bd35 2024-09-22 00:11:21 +02:00 Compare
cybik force-pushed main from 9bb363bd35 to 000b0dbf19 2024-09-22 00:34:52 +02:00 Compare
This pull request has changes conflicting with the target branch.
  • Makefile
  • debian/changelog
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u main:cybik-main
git checkout cybik-main
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: boot-packages/booster#3
No description provided.
Delete Branch "cybik/booster:main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?